FindBugs Bug Detector Report

The following document contains the results of FindBugs Report

FindBugs Version is 1.2.0

Threshold is Low

Effort is Default

Summary

ClassesBugsErrorsMissing Classes
2536700

Files

ClassBugs
net.sf.imca.model.AssociationComparator1
net.sf.imca.model.BoatBO1
net.sf.imca.model.CommitteeMemberComparator2
net.sf.imca.model.PersonBO4
net.sf.imca.model.entities.MembershipTypeEntity4
net.sf.imca.model.entities.SailEntity2
net.sf.imca.services.CommitteeService6
net.sf.imca.services.ImportData3
net.sf.imca.services.JoinImcaService4
net.sf.imca.services.LoginRegisterService1
net.sf.imca.services.ReflectionUtil4
net.sf.imca.services.Service1
net.sf.imca.services.UiService4
net.sf.imca.taglibs.Fleets2
net.sf.imca.taglibs.ImcaNationalCommittee3
net.sf.imca.taglibs.Riders2
net.sf.imca.web.DataAdminServlet2
net.sf.imca.web.RidersDataServlet2
net.sf.imca.web.backingbeans.CommitteeBean8
net.sf.imca.web.backingbeans.JoinBean3
net.sf.imca.web.backingbeans.LoginBean1
net.sf.imca.web.backingbeans.MemTypeBean3
net.sf.imca.web.backingbeans.MembershipTableModel3
net.sf.imca.web.backingbeans.MembershipTableModel$MembershipEntityData1

net.sf.imca.model.AssociationComparator

BugCategoryDetailsLine
net.sf.imca.model.AssociationComparator implements Comparator but not SerializableBAD_PRACTICESE_COMPARATOR_SHOULD_BE_SERIALIZABLENot available

net.sf.imca.model.BoatBO

BugCategoryDetailsLine
net.sf.imca.model.BoatBO.BoatBO(EntityManager, NodeList) ignores return value of java.lang.String.equals(Object)CORRECTNESSRV_RETURN_VALUE_IGNORED129

net.sf.imca.model.CommitteeMemberComparator

BugCategoryDetailsLine
Use of non-localized String.toUpperCase() or String.toLowerCaseI18NDM_CONVERT_CASE19
net.sf.imca.model.CommitteeMemberComparator implements Comparator but not SerializableBAD_PRACTICESE_COMPARATOR_SHOULD_BE_SERIALIZABLENot available

net.sf.imca.model.PersonBO

BugCategoryDetailsLine
Dead store to dbPerson in net.sf.imca.model.PersonBO.PersonBO(EntityManager, String, String)STYLEDLS_DEAD_LOCAL_STORE106
Use of non-localized String.toUpperCase() or String.toLowerCaseI18NDM_CONVERT_CASE460
Use of non-localized String.toUpperCase() or String.toLowerCaseI18NDM_CONVERT_CASE398
net.sf.imca.model.PersonBO.PersonBO(EntityManager, NodeList) checks to see if result of String.indexOf is positiveSTYLERV_CHECK_FOR_POSITIVE_INDEXOF226

net.sf.imca.model.entities.MembershipTypeEntity

BugCategoryDetailsLine
net.sf.imca.model.entities.MembershipTypeEntity.getValidFrom() may expose internal representation by returning MembershipTypeEntity.validFromMALICIOUS_CODEEI_EXPOSE_REP69
net.sf.imca.model.entities.MembershipTypeEntity.getValidTo() may expose internal representation by returning MembershipTypeEntity.validToMALICIOUS_CODEEI_EXPOSE_REP77
net.sf.imca.model.entities.MembershipTypeEntity.setValidFrom(Date) may expose internal representation by storing an externally mutable object into MembershipTypeEntity.validFromMALICIOUS_CODEEI_EXPOSE_REP273
net.sf.imca.model.entities.MembershipTypeEntity.setValidTo(Date) may expose internal representation by storing an externally mutable object into MembershipTypeEntity.validToMALICIOUS_CODEEI_EXPOSE_REP281

net.sf.imca.model.entities.SailEntity

BugCategoryDetailsLine
net.sf.imca.model.entities.SailEntity.getMeasuredDate() may expose internal representation by returning SailEntity.measuredDateMALICIOUS_CODEEI_EXPOSE_REP93
net.sf.imca.model.entities.SailEntity.setMeasuredDate(Date) may expose internal representation by storing an externally mutable object into SailEntity.measuredDateMALICIOUS_CODEEI_EXPOSE_REP297

net.sf.imca.services.CommitteeService

BugCategoryDetailsLine
Should net.sf.imca.services.CommitteeService.getAllAssociations() return a zero length array rather than null?STYLEPZLA_PREFER_ZERO_LENGTH_ARRAYS125
Should net.sf.imca.services.CommitteeService.getCommitteeMemberships(PersonBO) return a zero length array rather than null?STYLEPZLA_PREFER_ZERO_LENGTH_ARRAYS94
Should net.sf.imca.services.CommitteeService.getEditableMembershipTypes(PersonBO) return a zero length array rather than null?STYLEPZLA_PREFER_ZERO_LENGTH_ARRAYS474
Should net.sf.imca.services.CommitteeService.getMembershipList(PersonBO, Date) return a zero length array rather than null?STYLEPZLA_PREFER_ZERO_LENGTH_ARRAYS81
Should net.sf.imca.services.CommitteeService.getMembershipRequestList(PersonBO) return a zero length array rather than null?STYLEPZLA_PREFER_ZERO_LENGTH_ARRAYS237
Should net.sf.imca.services.CommitteeService.getOficialIMCACommitteeMemberships(PersonBO) return a zero length array rather than null?STYLEPZLA_PREFER_ZERO_LENGTH_ARRAYS106

net.sf.imca.services.ImportData

BugCategoryDetailsLine
net.sf.imca.services.ImportData.WEBSITE_HOST isn't final but should beMALICIOUS_CODEMS_SHOULD_BE_FINAL49
net.sf.imca.services.ImportData.WEBSITE_PROTOCAL isn't final but should beMALICIOUS_CODEMS_SHOULD_BE_FINAL47
Private method net.sf.imca.services.ImportData.getNodeListForDataFile(String, String) is never calledPERFORMANCEUPM_UNCALLED_PRIVATE_METHOD111-127

net.sf.imca.services.JoinImcaService

BugCategoryDetailsLine
Should net.sf.imca.services.JoinImcaService.getAreasForCountry(String) return a zero length array rather than null?STYLEPZLA_PREFER_ZERO_LENGTH_ARRAYS101
Should net.sf.imca.services.JoinImcaService.getImcaMemberships(PersonBO) return a zero length array rather than null?STYLEPZLA_PREFER_ZERO_LENGTH_ARRAYS206
Should net.sf.imca.services.JoinImcaService.selectAssociations(String) return a zero length array rather than null?STYLEPZLA_PREFER_ZERO_LENGTH_ARRAYS66
Redundant nullcheck of association, which is known to be non-null in net.sf.imca.services.JoinImcaService.getJoinableAssociation(String, String)STYLERCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE163

net.sf.imca.services.LoginRegisterService

BugCategoryDetailsLine
net.sf.imca.services.LoginRegisterService.register(String, String, String, String, String, String) checks to see if result of String.indexOf is positiveSTYLERV_CHECK_FOR_POSITIVE_INDEXOF96

net.sf.imca.services.ReflectionUtil

BugCategoryDetailsLine
net.sf.imca.services.ReflectionUtil.setEntityValuesFromParameterMap(Object, Hashtable) might ignore java.lang.ExceptionBAD_PRACTICEDE_MIGHT_IGNORE171
net.sf.imca.services.ReflectionUtil.setEntityValuesFromParameterMap(Object, Hashtable) invokes inefficient Boolean constructor; use Boolean.valueOf(...) insteadPERFORMANCEDM_BOOLEAN_CTOR169
Redundant nullcheck of value, which is known to be non-null in net.sf.imca.services.ReflectionUtil.setEntityValuesFromParameterMap(Object, Hashtable)STYLERCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE151
Exception is caught when Exception is not thrown in net.sf.imca.services.ReflectionUtil.setEntityValuesFromParameterMap(Object, Hashtable)STYLEREC_CATCH_EXCEPTION171

net.sf.imca.services.Service

BugCategoryDetailsLine
net.sf.imca.services.Service.startTransaction() might ignore java.lang.ExceptionBAD_PRACTICEDE_MIGHT_IGNORE58

net.sf.imca.services.UiService

BugCategoryDetailsLine
Method net.sf.imca.services.UiService.getMembersWithWebsites() invokes inefficient Long(long) constructor; use Long.valueOf(long) insteadPERFORMANCEDM_NUMBER_CTOR92
Method net.sf.imca.services.UiService.getMembersWithWebsites() invokes inefficient Long(long) constructor; use Long.valueOf(long) insteadPERFORMANCEDM_NUMBER_CTOR98
Should net.sf.imca.services.UiService.getAssociationsWithWebsites() return a zero length array rather than null?STYLEPZLA_PREFER_ZERO_LENGTH_ARRAYS67
Should net.sf.imca.services.UiService.getMembersWithWebsites() return a zero length array rather than null?STYLEPZLA_PREFER_ZERO_LENGTH_ARRAYS113

net.sf.imca.taglibs.Fleets

BugCategoryDetailsLine
Class net.sf.imca.taglibs.Fleets defines non-transient non-serializable instance field asssociationsBAD_PRACTICESE_BAD_FIELDNot available
Fleets.asssociations not initialized in constructorSTYLEUWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTORNot available

net.sf.imca.taglibs.ImcaNationalCommittee

BugCategoryDetailsLine
Redundant nullcheck of net.sf.imca.taglibs.ImcaNationalCommittee.committee, which is known to be non-null in net.sf.imca.taglibs.ImcaNationalCommittee.doStartTag()STYLERCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE44
Class net.sf.imca.taglibs.ImcaNationalCommittee defines non-transient non-serializable instance field committeeBAD_PRACTICESE_BAD_FIELDNot available
ImcaNationalCommittee.committee not initialized in constructorSTYLEUWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTORNot available

net.sf.imca.taglibs.Riders

BugCategoryDetailsLine
Class net.sf.imca.taglibs.Riders defines non-transient non-serializable instance field personsBAD_PRACTICESE_BAD_FIELDNot available
Riders.persons not initialized in constructorSTYLEUWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTORNot available

net.sf.imca.web.DataAdminServlet

BugCategoryDetailsLine
Invocation of toString on an array in net.sf.imca.web.DataAdminServlet.doEntityForm(PrintWriter, Object)CORRECTNESSDMI_INVOKING_TOSTRING_ON_ARRAY183
Invocation of toString on an array in net.sf.imca.web.DataAdminServlet.doTableRow(PrintWriter, Object)CORRECTNESSDMI_INVOKING_TOSTRING_ON_ARRAY346

net.sf.imca.web.RidersDataServlet

BugCategoryDetailsLine
Use of non-localized String.toUpperCase() or String.toLowerCaseI18NDM_CONVERT_CASE91
net.sf.imca.web.RidersDataServlet is Serializable; consider declaring a serialVersionUIDBAD_PRACTICESE_NO_SERIALVERSIONIDNot available

net.sf.imca.web.backingbeans.CommitteeBean

BugCategoryDetailsLine
net.sf.imca.web.backingbeans.CommitteeBean.getEndDate() may expose internal representation by returning CommitteeBean.endDateMALICIOUS_CODEEI_EXPOSE_REP188
net.sf.imca.web.backingbeans.CommitteeBean.getMemberList() may expose internal representation by returning CommitteeBean.memberListMALICIOUS_CODEEI_EXPOSE_REP212
net.sf.imca.web.backingbeans.CommitteeBean.getRefDate() may expose internal representation by returning CommitteeBean.refDateMALICIOUS_CODEEI_EXPOSE_REP309
net.sf.imca.web.backingbeans.CommitteeBean.getStartDate() may expose internal representation by returning CommitteeBean.startDateMALICIOUS_CODEEI_EXPOSE_REP180
net.sf.imca.web.backingbeans.CommitteeBean.setEndDate(Date) may expose internal representation by storing an externally mutable object into CommitteeBean.endDateMALICIOUS_CODEEI_EXPOSE_REP2192
net.sf.imca.web.backingbeans.CommitteeBean.setMemberList(MembershipEntity[]) may expose internal representation by storing an externally mutable object into CommitteeBean.memberListMALICIOUS_CODEEI_EXPOSE_REP2216
net.sf.imca.web.backingbeans.CommitteeBean.setRefDate(Date) may expose internal representation by storing an externally mutable object into CommitteeBean.refDateMALICIOUS_CODEEI_EXPOSE_REP2313
net.sf.imca.web.backingbeans.CommitteeBean.setStartDate(Date) may expose internal representation by storing an externally mutable object into CommitteeBean.startDateMALICIOUS_CODEEI_EXPOSE_REP2184

net.sf.imca.web.backingbeans.JoinBean

BugCategoryDetailsLine
Method net.sf.imca.web.backingbeans.JoinBean.updateMembershipTypeItems() invokes inefficient Long(long) constructor; use Long.valueOf(long) insteadPERFORMANCEDM_NUMBER_CTOR117
net.sf.imca.web.backingbeans.JoinBean.getAreaItems() may expose internal representation by returning JoinBean.areaItemsMALICIOUS_CODEEI_EXPOSE_REP90
net.sf.imca.web.backingbeans.JoinBean.getMembershipTypeItems() may expose internal representation by returning JoinBean.membershipTypeItemsMALICIOUS_CODEEI_EXPOSE_REP104

net.sf.imca.web.backingbeans.LoginBean

BugCategoryDetailsLine
Dead store to webUser in net.sf.imca.web.backingbeans.LoginBean.actionLogout()STYLEDLS_DEAD_LOCAL_STORE75

net.sf.imca.web.backingbeans.MemTypeBean

BugCategoryDetailsLine
Dead store to association in net.sf.imca.web.backingbeans.MemTypeBean.setCountryCode(String)STYLEDLS_DEAD_LOCAL_STORE99
net.sf.imca.web.backingbeans.MemTypeBean.getMembershipTypeItems() may expose internal representation by returning MemTypeBean.membershipTypeItemsMALICIOUS_CODEEI_EXPOSE_REP126
net.sf.imca.web.backingbeans.MemTypeBean.setMembershipTypeItems(SelectItem[]) may expose internal representation by storing an externally mutable object into MemTypeBean.membershipTypeItemsMALICIOUS_CODEEI_EXPOSE_REP2130

net.sf.imca.web.backingbeans.MembershipTableModel

BugCategoryDetailsLine
net.sf.imca.web.backingbeans.MembershipTableModel.getMembershipData() may expose internal representation by returning MembershipTableModel.membershipDataMALICIOUS_CODEEI_EXPOSE_REP20
net.sf.imca.web.backingbeans.MembershipTableModel.setMembershipData(MembershipTableModel$MembershipEntityData[]) may expose internal representation by storing an externally mutable object into MembershipTableModel.membershipDataMALICIOUS_CODEEI_EXPOSE_REP226
Unread field: net.sf.imca.web.backingbeans.MembershipTableModel.modelPERFORMANCEURF_UNREAD_FIELD11

net.sf.imca.web.backingbeans.MembershipTableModel$MembershipEntityData

BugCategoryDetailsLine
Should net.sf.imca.web.backingbeans.MembershipTableModel$MembershipEntityData be a _static_ inner class?PERFORMANCESIC_INNER_SHOULD_BE_STATICNot available